feat(starknet_os): add stateful compression hints #4101
Conversation
|
This change is |
dorimedini-starkware
force-pushed
the
02-11-feat_starknet_os_fix_enter_syscall_hints
branch
from
44da110 to
a12c921
Compare
dorimedini-starkware
force-pushed
the
02-11-feat_starknet_os_add_stateful_compression_hints
branch
from
5b80c58 to
39f52b7
Compare
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions
crates/starknet_os/src/hints/enum_definition.rs line 506 at r1 (raw file):
indoc! {r#"from starkware.starknet.definitions.constants import ALIAS_CONTRACT_ADDRESS # This hint shouldn't be whitelisted.
what does this mean?
Code quote:
# This hint shouldn't be whitelisted.crates/starknet_os/src/hints/enum_definition.rs line 529 at r1 (raw file):
AssertKeyBigEnoughForAlias, assert_key_big_enough_for_alias, r#"assert ids.key >= ids.MIN_VALUE_FOR_ALIAS_ALLOC, f"Key {ids.key} is too small."#
you're missing " at the end of the string
Code quote:
r#"assert ids.key >= ids.MIN_VALUE_FOR_ALIAS_ALLOC, f"Key {ids.key} is too small."#There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @amosStarkware)
crates/starknet_os/src/hints/enum_definition.rs line 506 at r1 (raw file):
Previously, amosStarkware wrote…
what does this mean?
Not sure; part of the hint string. will ask internally
crates/starknet_os/src/hints/enum_definition.rs line 529 at r1 (raw file):
Previously, amosStarkware wrote…
you're missing
"at the end of the string
nice catch!
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
dorimedini-starkware
force-pushed
the
02-11-feat_starknet_os_add_stateful_compression_hints
branch
from
39f52b7 to
76c5b61
Compare
dorimedini-starkware
changed the base branch from
02-11-feat_starknet_os_fix_enter_syscall_hints
to
main
|
Artifacts upload workflows: |
There was a problem hiding this comment.
Reviewed 1 of 112 files at r2, all commit messages.
Reviewable status: 3 of 158 files reviewed, 1 unresolved discussion
There was a problem hiding this comment.
Reviewed 111 of 112 files at r2.
Reviewable status: 114 of 158 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 111 of 112 files at r2, all commit messages.
Reviewable status: 114 of 158 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 112 files at r2.
Reviewable status: 114 of 158 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 3 files at r1.
Reviewable status: 114 of 158 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 44 of 156 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
No description provided.