Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional prover parameters file path to the adapted Stwo CLI #410

Closed
wants to merge 2 commits into from

Conversation

m-kus
Copy link
Collaborator

@m-kus m-kus commented Jan 29, 2025

Similarly to Stone which had prover config and parameters files, this PR introduces an optional cmd argument pointing to the params file.

The expected format is the following:

{
    "channel_hash": "blake2s",
    "pcs_config": {
        "pow_bits": 24,
        "fri_config": {
            "log_last_layer_degree_bound": 0,
            "log_blowup_factor": 2,
            "n_queries": 36
        }
    }
}

If the file is not specified, the defaults are set to ensure 96 bits of security.


This change is Reviewable

@m-kus m-kus force-pushed the m-kus/config-file branch 2 times, most recently from 72a9c3f to df1d498 Compare January 29, 2025 18:50
@m-kus
Copy link
Collaborator Author

m-kus commented Jan 30, 2025

@ohad-starkware can you please take a look? 🙏

@m-kus m-kus force-pushed the m-kus/config-file branch from df1d498 to f356913 Compare January 30, 2025 13:34
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be 3-4 separate prs,

  1. bump stwo
  2. hash type in the cli
  3. pcs config in the proof
    4.default parameters

I believe this is under @yuvalsw jurisdiction

Reviewable status: 0 of 19 files reviewed, all discussions resolved

@m-kus
Copy link
Collaborator Author

m-kus commented Jan 30, 2025

Ok thanks, I'll split into several PRs!
Note that (1) would result in cairo-serialize build error, so maybe (1) + (3) is ok?

Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, u decide

Reviewable status: 0 of 19 files reviewed, all discussions resolved

@m-kus m-kus force-pushed the m-kus/config-file branch from b321756 to e157c2c Compare February 4, 2025 15:16
@m-kus m-kus closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants