Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track range checks #417

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Jan 30, 2025

This change is Reviewable

@ohad-starkware ohad-starkware force-pushed the ohad/track_range_checks_relations branch from d7c4db3 to d63d5aa Compare January 30, 2025 11:30
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)


stwo_cairo_prover/crates/prover/src/cairo_air/debug_tools.rs line 18 at r1 (raw file):

use super::air::CairoClaim;
use crate::components::range_check_vector::{
    range_check_12, range_check_18, range_check_3_6, range_check_3_6_6_3,

WDYT about using all of the range checks created by range check vector here?

Copy link
Contributor Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare and @ohad-starkware)


stwo_cairo_prover/crates/prover/src/cairo_air/debug_tools.rs line 18 at r1 (raw file):

Previously, Gali-StarkWare wrote…

WDYT about using all of the range checks created by range check vector here?

Done.

@ohad-starkware ohad-starkware force-pushed the ohad/track_range_checks_relations branch from d63d5aa to 54842a2 Compare January 30, 2025 14:18
Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

@ohad-starkware ohad-starkware merged commit 50aa9b4 into main Feb 3, 2025
7 checks passed
@ohad-starkware ohad-starkware deleted the ohad/track_range_checks_relations branch February 3, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants