-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track range checks #417
track range checks #417
Conversation
d7c4db3
to
d63d5aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)
stwo_cairo_prover/crates/prover/src/cairo_air/debug_tools.rs
line 18 at r1 (raw file):
use super::air::CairoClaim; use crate::components::range_check_vector::{ range_check_12, range_check_18, range_check_3_6, range_check_3_6_6_3,
WDYT about using all of the range checks created by range check vector here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare and @ohad-starkware)
stwo_cairo_prover/crates/prover/src/cairo_air/debug_tools.rs
line 18 at r1 (raw file):
Previously, Gali-StarkWare wrote…
WDYT about using all of the range checks created by range check vector here?
Done.
d63d5aa
to
54842a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
This change is