Update existing components

[andrewmilson]

This change is 

[andrewmilson]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Fix 'offset overflow' bug #430
• Proof gen and verify #429
• Add opcode components #428
• Update existing components #427 👈 (View in Graphite)
• Remove jump_t_t_f opcode #426 : 1 other dependent PR (#460 )
• Update names of lookup elements #425
• Update component interface to use preprocessed set #424
• Update FRI first layer folding #458
• Update Scarb version #459
• Add preprocessed column set #391
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[shaharsamocha7]

Reviewed 7 of 27 files at r1.
Reviewable status: 7 of 27 files reviewed, 4 unresolved discussions (waiting on @andrewmilson)

---

stwo_cairo_verifier/crates/cairo_air/src/components/range_check_vector/rc_19_constraints.cairo line 87 at r1 (raw file):

        .try_into()
        .unwrap())
        .unbox();

Isn't pop_front expensive?
we should consider to remove the arrays and just store the values directly

Code quote:

        (*interaction_mask_values
        .pop_front()
        .unwrap()
        .span()
        .try_into()
        .unwrap())
        .unbox();

---

stwo_cairo_verifier/crates/cairo_air/src/components/range_check_vector/rc_4_3_constraints.cairo line 170 at r1 (raw file):

    (RangeCheck_4_3_alpha0) * (trace_1_column_0_offset_0)
        + (RangeCheck_4_3_alpha1) * (trace_1_column_1_offset_0)
        - (RangeCheck_4_3_z)

consider to remove this code and add combine function that just take alpha,z

Code quote:

) -> QM31 {
    (RangeCheck_4_3_alpha0) * (trace_1_column_0_offset_0)
        + (RangeCheck_4_3_alpha1) * (trace_1_column_1_offset_0)
        - (RangeCheck_4_3_z)

---

stwo_cairo_verifier/crates/cairo_air/src/components/memory_id_to_big/constraints_small.cairo line 385 at r1 (raw file):

    sum = sum * random_coeff + constraint_quotient;

    // Constrait 1

Suggestion:

/ Constraint 1

---

stwo_cairo_verifier/crates/cairo_air/src/components/memory_id_to_big/constraints_small.cairo line 458 at r1 (raw file):

            ],
        ))
        + (claimed_sum) * (qm31(32768, 0, 0, 0)))

I think that maybe this 32768 is wrong, I thought that it should be different number for each component
Will check

Code quote:

+ (claimed_sum) * (qm31(32768, 0, 0, 0)))

[andrewmilson]

Reviewable status: 7 of 27 files reviewed, 4 unresolved discussions (waiting on @shaharsamocha7)

---

stwo_cairo_verifier/crates/cairo_air/src/components/memory_id_to_big/constraints_small.cairo line 458 at r1 (raw file):

Previously, shaharsamocha7 wrote…

I think that maybe this 32768 is wrong, I thought that it should be different number for each component
Will check

Yeah you're correct. Those changes are in a later PR.
Currently it needs to modified it manually which I forgot to do here.
It's supposed to be 1/(1 << log_size) but the expressions don't currently express this.

---

stwo_cairo_verifier/crates/cairo_air/src/components/memory_id_to_big/constraints_small.cairo line 385 at r1 (raw file):

    sum = sum * random_coeff + constraint_quotient;

    // Constrait 1

Thanks. Modified in last PR to avoid crazy conflicts