[5.x] Asset Container returns relative url for same site #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edalzell
reviewed
Jan 20, 2025
| if (str_starts_with($url, config('app.url'))) { | ||
| $url = substr($url, strlen(config('app.url'))); | ||
| } | ||
|
|
There was a problem hiding this comment.
why not Str::removeLeft here?
There was a problem hiding this comment.
@edalzell I only found Str::chopStart() but that's not available in Laravel 10, so I did it the traditional way but if that's available... sure! Much nicer. Will check... Should have ask my coworker.
There was a problem hiding this comment.
You certainly should have. It's a Statamic function not Laravel, they extend Laravel's Str.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11371