-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storing emoji values for Custom Emoji Thumbnails for Community Channels #2366
Conversation
Hey @Parveshdhull, and thank you so much for making your first pull request in status-go! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2 |
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (24)
|
6579e57
to
e52f28c
Compare
It seems that the protobuf library was updated in this PR. Would it be possible to do so in a separate PR? |
e52f28c
to
95fee77
Compare
Thanks, @richard-ramos, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Parveshdhull thank you for your work on this PR. Can I ask what is the desired process flow you want to implement with these changes?
Hi @Samyoul, Currently, channels only storing color values and thumbnail is being created with the help of the first alphabet of the channel name. Now It will store an extra field(emoji) and thumbnail will be created with the help of both(background color and emoji). Issue: status-im/status-mobile#12375 PS: I will update this PR too after running |
7ed95cf
to
f1a27dd
Compare
f1a27dd
to
5e7d9c5
Compare
This PR stores emoji values which are required for creating custom emoji thumbnails
status-react PR:
status-im/status-mobile#12594