Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing emoji values for Custom Emoji Thumbnails for Community Channels #2366

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Sep 15, 2021

This PR stores emoji values which are required for creating custom emoji thumbnails

status-react PR:

status-im/status-mobile#12594

@ghost
Copy link

ghost commented Sep 15, 2021

Hey @Parveshdhull, and thank you so much for making your first pull request in status-go! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

@ghost
Copy link

ghost commented Sep 15, 2021

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile or desktop version?

@status-im-auto
Copy link
Member

status-im-auto commented Sep 15, 2021

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6579e57 #1 2021-09-15 22:14:58 ~3 min linux 📦zip
✔️ 6579e57 #1 2021-09-15 22:16:40 ~5 min ios 📦zip
✔️ 6579e57 #1 2021-09-15 22:18:39 ~7 min android 📦aar
e52f28c #2 2021-09-16 21:48:15 ~45 sec linux 📄log
✔️ e52f28c #2 2021-09-16 21:53:28 ~6 min android 📦aar
✔️ e52f28c #2 2021-09-16 21:53:47 ~6 min ios 📦zip
✔️ 95fee77 #3 2021-09-16 22:44:58 ~2 min ios 📦zip
✔️ 95fee77 #3 2021-09-16 22:45:08 ~2 min linux 📦zip
✔️ 95fee77 #3 2021-09-16 22:46:53 ~4 min android 📦aar
952b4b4 #4 2021-09-20 17:26:19 ~59 sec linux 📄log
✔️ 952b4b4 #4 2021-09-20 17:28:02 ~2 min ios 📦zip
✔️ 952b4b4 #4 2021-09-20 17:31:56 ~6 min android 📦aar
✔️ 9ce40ec #5 2021-09-20 17:38:36 ~1 min ios 📦zip
✔️ 9ce40ec #5 2021-09-20 17:39:35 ~2 min linux 📦zip
✔️ 9ce40ec #5 2021-09-20 17:45:08 ~8 min android 📦aar
✔️ 96be68b #6 2021-09-20 18:35:59 ~1 min ios 📦zip
✔️ 96be68b #6 2021-09-20 18:36:56 ~2 min linux 📦zip
✔️ 96be68b #6 2021-09-20 18:38:19 ~4 min android 📦aar
✔️ 1dc04b5 #7 2021-09-20 23:12:02 ~2 min ios 📦zip
✔️ 1dc04b5 #7 2021-09-20 23:12:30 ~2 min linux 📦zip
✔️ 1dc04b5 #7 2021-09-20 23:14:40 ~5 min android 📦aar
✔️ 7ed95cf #8 2021-09-24 17:10:09 ~3 min ios 📦zip
✔️ 7ed95cf #8 2021-09-24 17:10:34 ~4 min linux 📦zip
✔️ 7ed95cf #8 2021-09-24 17:11:34 ~5 min android 📦aar
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f1a27dd #9 2021-09-24 17:32:30 ~1 min ios 📦zip
✔️ f1a27dd #9 2021-09-24 17:33:53 ~3 min linux 📦zip
✔️ f1a27dd #9 2021-09-24 17:37:12 ~6 min android 📦aar
✔️ 5e7d9c5 #10 2021-10-04 12:43:32 ~2 min linux 📦zip
✔️ 5e7d9c5 #10 2021-10-04 12:45:54 ~4 min ios 📦zip
✔️ 5e7d9c5 #10 2021-10-04 12:47:10 ~5 min android 📦aar

@Parveshdhull Parveshdhull force-pushed the feature/custom_channel_thumbnails branch from 6579e57 to e52f28c Compare September 16, 2021 21:47
@richard-ramos
Copy link
Member

It seems that the protobuf library was updated in this PR. Would it be possible to do so in a separate PR?
Also, the build failing might be fixed by executing make vendor to update the dependencies inside the vendor/ folder

@Parveshdhull
Copy link
Member Author

It seems that the protobuf library was updated in this PR. Would it be possible to do so in a separate PR?
Also, the build failing might be fixed by executing make vendor to update the dependencies inside the vendor/ folder

Thanks, @richard-ramos, make vendor fixed the build issue. Also, I made separate PR for updating the protobuf library👍

Copy link
Member

@Samyoul Samyoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Parveshdhull thank you for your work on this PR. Can I ask what is the desired process flow you want to implement with these changes?

@Parveshdhull
Copy link
Member Author

Parveshdhull commented Sep 20, 2021

Hey @Parveshdhull thank you for your work on this PR. Can I ask what is the desired process flow you want to implement with these changes?

Hi @Samyoul,
I want to store emoji values for generating emoji thumbnails for community channels.

Currently, channels only storing color values and thumbnail is being created with the help of the first alphabet of the channel name. Now It will store an extra field(emoji) and thumbnail will be created with the help of both(background color and emoji).

Issue: status-im/status-mobile#12375
Status-React PR: status-im/status-mobile#12594
Thanks

PS: I will update this PR too after running make setup 👍 #2368

@Parveshdhull Parveshdhull force-pushed the feature/custom_channel_thumbnails branch 6 times, most recently from 7ed95cf to f1a27dd Compare September 24, 2021 17:30
@Parveshdhull Parveshdhull force-pushed the feature/custom_channel_thumbnails branch from f1a27dd to 5e7d9c5 Compare October 4, 2021 12:41
@Parveshdhull Parveshdhull merged commit c3ced09 into develop Oct 4, 2021
@Parveshdhull Parveshdhull deleted the feature/custom_channel_thumbnails branch October 4, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants