feat(telemetry)_: replace telemetry with prometheus metrics #6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (32)
|
adklempner
force-pushed
the
feat/replace-telemetry-prometheus
branch
3 times, most recently
from
7c4ff40 to
3763072
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6256 +/- ##
===========================================
- Coverage 61.55% 61.41% -0.15%
===========================================
Files 842 843 +1
Lines 110604 110400 -204
===========================================
- Hits 68086 67799 -287
- Misses 34562 34640 +78
- Partials 7956 7961 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vpavlin
reviewed
Jan 16, 2025
metrics/wakumetrics/metrics.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| MessagesSentTotal = prometheus.NewHistogramVec( |
There was a problem hiding this comment.
Why is SomethingSomethingTotal a histogram? Shouldn't it be just a normal counter? How do you plan to use it as histogram?
vpavlin
reviewed
Jan 16, 2025
| }, | ||
| ) | ||
|
|
||
| PeersByOrigin = prometheus.NewGaugeVec( |
There was a problem hiding this comment.
Are these currently connected peers or overall number? Cause I'd expect PeersByOrigin to be only increasing as new are discovered (i.e. Counter)?
There was a problem hiding this comment.
This is based on currently connected peers obtained by periodically looking at Waku's peer store
adklempner
force-pushed
the
feat/replace-telemetry-prometheus
branch
from
3763072 to
5f8d5f6
Compare
Replace telemetry with local metrics using prometheus client. Add parameters to InitializeApplication for enabling waku metrics over prometheus and specifying which port to use.
adklempner
force-pushed
the
feat/replace-telemetry-prometheus
branch
from
5f8d5f6 to
07798db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace telemetry with local metrics using prometheus. Add parameters to InitializeApplication for enabling waku metrics over prometheus and specifying which port to use.
This commit removes the telemetry functionality with a Prometheus client. Most of the metrics that were collected by telemetry now have their corresponding Prometheus gauges, counters, and histograms.
They still require a telemetry url to be set in order to be enabled. Additionally, the parameter
WakuMetricsEnabledneeds to be set as true in the request forInitializeApplicationin order to start Prometheus at port 9305 (can be changed usingWakuMetricsPort).status-desktopDogfooding PR: status-im/status-desktop#17020