Add blur overlay for bottom tabs and shell top nav #14783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (81)
|
Parveshdhull
force-pushed
the
feat/switcher-leftover
branch
2 times, most recently
from
4a9182f to
df259f4
Compare
Parveshdhull
force-pushed
the
feat/switcher-leftover
branch
2 times, most recently
from
1e8bc1d to
179104a
Compare
Parveshdhull
force-pushed
the
feat/switcher-leftover
branch
5 times, most recently
from
0e41ec1 to
9dcc106
Compare
Parveshdhull
commented
Jan 23, 2023
| "@react-native-community/blur": "git+https://github.com/Kureev/react-native-blur#refs/tags/v3.6.1", | ||
| "@react-native-community/blur": "git+https://github.com/status-im/react-native-blur#refs/tags/v4.3.0-status", |
There was a problem hiding this comment.
the react-native-blur library currently doesn't support the trasnparent blur type for ios, as mentioned in Issues Kureev/react-native-blur#292 Kureev/react-native-blur#407.
But currently, a PR is out that adds this functionality. So currently we are forking the library and applying that patch.
This patch works great with several colors, except a few colors like our neutral-100. With our neutral-100 it creates a partially visible blue overlay as shown in the image. Still, it is much better than old blur types like light, and dark. So for now we are using this version with a patch for release and will improve it more later.
(will create issue for that)
UPD: #14903
| (:count :permission) [:<>]) ;; Add components for these cases | ||
| (:count :permission) [:<>] ;; Add components for these cases | ||
|
|
||
| nil) |
There was a problem hiding this comment.
Adding default nil values for switcher case uses, so that app doesn't crash if gets unmatch key.
Parveshdhull
changed the title
Parveshdhull
requested review from
siddarthkay,
OmarBasem,
yqrashawn,
flexsurfer and
jo-mut
84% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMediumMultipleDeviceNewUI:
Class TestActivityCenterMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (21)Click to expandClass TestCommunityOneDeviceMerged:
Class TestDeeplinkOneDeviceNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterMultipleDevicePR:
|
Parveshdhull
force-pushed
the
feat/switcher-leftover
branch
4 times, most recently
from
4208424 to
294ce8a
Compare
flexsurfer
approved these changes
Jan 25, 2023
85% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityCenterMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (22)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestGroupChatMediumMultipleDeviceNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestDeeplinkOneDeviceNewUI:
Class TestCommunityOneDeviceMerged:
|
100% of end-end tests have passedPassed tests (1)Click to expandClass TestActivityCenterMultipleDevicePR:
|
|
@Parveshdhull thanx for the PR. Tested, no regression found. I would like to clarify if I should see any visual differences for bottom tabs comparing to nightly build? |
Hi @pavloburykh, Thank you for testing the PR. Sorry, my PR description was not that clear. As this PR adds blur overlay over the bottom tabs, they are sure going to look visually different. So testing was to avoid problems like that (if exist) |
Thanx for the explanation @Parveshdhull Could you please show what exact difference should be comparing to nightly? Sorry I just not able to notice any. Maybe I am looking at wrong direction. |
Parveshdhull
force-pushed
the
feat/switcher-leftover
branch
from
2fda155 to
e377d74
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add blur overlay for bottom tabs and shell top nav
Note: This is just initial implementation of bottom tabs blur, needs further improvement. Especially for ios.
Testing
PR doesn't add new flow, so there isn't much to test.
Please just test for any visible regressions in the home stack, shell, bottom tabs animations, etc.
Known Issue:
IOS blur overlay is blue
status: ready