feat: activity centre animations #15262
Conversation
Jenkins BuildsClick to see older builds (8)
|
@flexsurfer The modal from React Native is smoother. RNN only has a modal for Android, and it seems to be animating on the JS thread. For iOS, they have no modal, and they recommend using modal from React Native. |
that's weird, the whole point of RNN is that it's written in native code, we need to double check |
if you mean this its only for |
|
RNN should be more performant, because modal is native, separate native container, in the RN its just view inside react tree, so it will be slower for sure, but that's my guess |
|
we have |
|
we've never had any issues with it, we have lots of modals |
|
Hey @flexsurfer, I think I wasn't clear. I am talking about "Modal component" not "Modal screen". Unfortunately, using a screen is it not possible for the transparent blurry background design. So we are using a Modal component. The I was hoping RNN modal to look better on Android, but unfortunately it does not. I also tried checking other modal libs: https://github.com/jeremybarbet/react-native-modalize, https://gorhom.github.io/react-native-bottom-sheet/ |
|
from your videos, i don't see the point of having a transparent screen, if the design team really wants a blur effect, can we just use a fake blur image as a background? btw on ios demo there is no blur |
|
@flexsurfer I don't like the transparent background either. I have suggested to @ilmotta to have a fake background before #14968 (comment) but he is saying he chatted with the design team and John before over this, and they are not accepting design changes regarding that background. My guess is that they want the activity center to look similar to the notifications center on iOS and Android, as we are supposed to be building a "super app" that looks like an Operating System. There is a blur on the iOS demo, maybe I need to reduce it a little on iOS. |
could you elaborate please |
@flexsurfer setting the background color as transparent to a screen will just be white |
updates updates updates updates updates updates updates updates
OmarBasem
force-pushed
the
activity-centre-animations
branch
from
08492da to
1942a32
Compare
fixed #15268 |
fixes: #15261
This PR migrates activity centre away from using the
popovercomponent to usingModalcomponent from React Native, plus some minor changes.This PR introduces the following improvements:
And here how it looks:
-> on iOS:
Simulator.Screen.Recording.-.iPhone.13.Pro.-.2023-03-06.at.14.10.47.mp4
-> and Android:
Screen_Recording_20230306-092344_Status.PR_1.mp4