feat: doc info boxes while onboarding #15697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (58)
|
flexsurfer
changed the title
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
4 times, most recently
from
d82c0e2 to
f08bc9e
Compare
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
4 times, most recently
from
18ced7a to
2c81b20
Compare
yqrashawn
requested review from
ulisesmac,
J-Son89,
Parveshdhull and
ajayesivan
and removed request for
ulisesmac and
J-Son89
Parveshdhull
approved these changes
May 5, 2023
J-Son89
reviewed
May 5, 2023
| @@ -58,3 +58,7 @@ | |||
| [] | |||
| {:margin-bottom (if platform/android? 20 46)}) | |||
|
|
|||
| (def forget-password-doc-container {:margin-right 16}) | |||
| (def forget-password-step-container {:flex-direction :row :margin-top 14}) | |||
There was a problem hiding this comment.
nit, consider aligning the keys of this map
There was a problem hiding this comment.
You mean like this? Lint won't pass.
(def forget-password-doc-container {:margin-right 16})
(def forget-password-step-container {:flex-direction :row :margin-top 14})
J-Son89
reviewed
May 5, 2023
J-Son89
reviewed
May 5, 2023
translations/en.json
Outdated
| @@ -956,6 +958,13 @@ | |||
| "name-of-token": "The name of your token", | |||
| "need-help": "Need help?", | |||
| "new-to-status": "I’m new to Status", | |||
| "getting-started-with-status": "Getting started with Status", | |||
| "getting-started-description": "Something here about what keys are and how great and important they are.\n\nYour options:", | |||
There was a problem hiding this comment.
hmm, I don't think it's beneficial to add these messages which are not ready from design/ documentation team to the translations strings.
It would be better to just use a plain string message and include a todo in the file to update them with the correct translations strings once ready from the respective teams.
cc @pedro-et @jorge-campo
There was a problem hiding this comment.
Hey @J-Son89 , from Documentation, the messages in Onboarding are ready and in the Figma file (yellow cards). I guess this was overlooked (?)
Please, see this Figma link and let me know if I can be of any help.
There was a problem hiding this comment.
ah thanks @jorge-campo! @yqrashawn can you update with the finalized copy 👍
There was a problem hiding this comment.
@yqrashawn, let me know if you need anything else. Happy to help.
Note
We're aware that the final copy in the yellow cards is longer than the one in the mockups. Users will need to scroll to read the entire text.
J-Son89
approved these changes
May 5, 2023
yqrashawn
changed the title
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
2 times, most recently
from
7c9ac59 to
91c62e7
Compare
|
@yqrashawn, I've noticed the yellow card about the Status Profile Password (see image) is missing a title. I added a comment on the Figma file. Could you please add the title to the text? Thank you!
|
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
2 times, most recently
from
37a52cd to
874a3cb
Compare
|
@J-Son89 @jorge-campo new copy added, also updated the screenshots |
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
2 times, most recently
from
c36ab8c to
d5300f8
Compare
ajayesivan
approved these changes
May 8, 2023
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
from
d5300f8 to
f38e980
Compare
|
Hey @yqrashawn, thanks for the PR! Android: 
Figma / iOS: 
|
|
@qoqobolo Not on purpose. It's a known issue Kureev/react-native-blur#511 and discussed here #15440 (comment) |
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
from
f38e980 to
ed4cb66
Compare
|
@yqrashawn got it, thanks for sharing the issue! |
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
from
ed4cb66 to
0fd7a33
Compare
fix #15017 Signed-off-by: yqrashawn <[email protected]>
Signed-off-by: yqrashawn <[email protected]>
Signed-off-by: yqrashawn <[email protected]>
yqrashawn
force-pushed
the
feat/onboarding-doc-infobox
branch
from
0fd7a33 to
7afabed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add info box for
add copy of forgot password, the info box of for this is blocked by step component Implement Quo2 component Step #15696waiting for the doc drawer component to be merged #15674fix #15017
status: ready