-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto register ide-helper hook using Package Discovery #215
Conversation
Hi @daniel-de-wit, |
This package should not be installed on a production environment, therefore we don't need to check it.
…ider Ensures the hook is only registered after the ModelsCommand is called.
@staudenmeir I've updated the PR to make the service provider deferred, just like the one from IDEHelper. This ensures the order of package discovery doesn't effect the registration of the model hook. Now it only registers after the ModelsCommand is requested from the service container, which removed the need for a couple of environment guards. I would like to hear your take on it |
# Conflicts: # composer.json
Thanks, excellent PR! I've released a new version. |
One last question: You kept and even improved the README section about manually enabling the model hook. Do you still see a use case for that? |
I added that for people that have package discovery disabled. I never encountered a project that disabled the entire package discovery though. |
Ok, thanks. |
Would you consider automatically registering the model hook using Package Discovery?