Adjust pup to pass specific ENV vars down to build and workflow steps #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 28, 2024 15:29
Some commands need environment variables to be set in order to function correctly (example: `NODE_AUTH_TOKEN` for use in installing private npm packages) This change sets a default set of env vars that can get passed down to commands (`NODE_AUTH_TOKEN`) and `.puprc` files can add additional `env` entries to expand the ENV vars that pup will handle.
bordoni
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some commands need environment variables to be set in order to function correctly (example:
NODE_AUTH_TOKENfor use in installing private npm packages)This change sets a default set of env vars that can get passed down to commands (
NODE_AUTH_TOKEN) and.puprcfiles can add additionalenventries to expand the ENV vars that pup will handle.The Files Changed on this PR looks intimidating, but most of those changes are the snapshots.