Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make glz::async_map copyable and movable #1468

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stephenberry
Copy link
Owner

@stephenberry stephenberry commented Dec 3, 2024

DO NOT MERGE YET. MUST DETERMINE IF THE MAP ITSELF SHOULD BE SHARED OR JUST THE ELEMENTS.

// The async_map is copyable, but it only performs shallow copies
// This is to allow values like `std::atomic<int>` (and other thread safe types) to be held
// So, copying an async_map will result in a shared reference to the data
// In a multi-threading context this is often the desired behavior as thread safe logic
// is typically attempting to shared state across threads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant