[Json] - Fix enum string read for vector of pairs in concatenate mode #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this pull request! I'll try to look it over soon. |
sjanel
force-pushed
the
bugfix/fix-json-read-enum-string-vector-pair-concatenate
branch
from
3411579 to
0cc21a1
Compare
|
I think this makes sense, it allows for quoted enum parsing in vectors of pairs. I'll merge it in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an
expected_quoteparsing error occurring for objects of typevector<std::pair<MyEnum, ...>when in concatenate mode and if user requests parsing of enums as strings.This PR takes the assumption that
is
trueif and only if the enum needs to be serialized / de-serialized as strings instead of values (based on my findings). Please help me correct the code if this assumption is wrong.Updated the unit tests accordingly.