-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Eigen::Transform #1555
Conversation
# Conflicts: # include/glaze/ext/eigen.hpp # tests/eigen_test/eigen_test.cpp
The unit test failed at |
Now I am certain it's a precision issue. I checked other unit tests, and none of them have such high-precision testing, so I removed the high-precision unit test. Perhaps this issue should be addressed in a separate PR? Or maybe it doesn't need to be fixed? |
I don't think this is a Glaze issue, because it is robustly tested for floating point round-tripping (every possible float is tested and random doubles). This is probably a precision issue with the way floating point assembly is generated for Eigen. Floating point math operations with Eigen aren't guaranteed to give the exact same result across compilers. |
Thanks for adding this support! Do you think it is ready to be merged? |
Totally agree |
And yes I think it is ready to be merged |
Sweet! Merged it in. |
No description provided.