fix: take into account prompt size in nui and builtin selects #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Width calculation logic in nui and builtin selects ignores prompt size. This makes it very easy to lose crucial information required to make a decision.
For example, here's what I see when running
LspStart
with thevtsls
language server with master ofstevearc/dressing.nvim
:And here's what I see with this PR:
Description
Initialize
max_width
(builtin) orline_width
(nui) to the prompt length if it exists. Otherwise fallback to previous value of 1.Test Plan
Used the manual select test with the following configuration:
Before
After