Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementations of head_mut, get_mut, index_mut and improve docs #16

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Implementations of head_mut, get_mut, index_mut and improve docs #16

merged 1 commit into from
Jan 10, 2019

Conversation

ehsanmok
Copy link
Contributor

@ehsanmok ehsanmok commented Oct 25, 2018

This PR adds some more convenient mutable counterparts of head(), get() and index() methods.

Also some minor improvement in docs related to this and the already supported into_iter.

Copy link
Owner

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! I have just one comment about some removed comments. Sorry this took me so long to review.

src/lib.rs Show resolved Hide resolved
@steveklabnik
Copy link
Owner

Ah, this has a merge conflict now, can you rebase it? Sorry about that!

@ehsanmok
Copy link
Contributor Author

ehsanmok commented Jan 8, 2019

@steveklabnik sure, no worries!

Also wanted to say, thank you for all your contributions to Rust. Without determinations like yours, we (community) wouldn't have such an awesome language to spend our time, enjoy and make a difference ❤️

@steveklabnik steveklabnik merged commit a2e7f31 into steveklabnik:master Jan 10, 2019
@steveklabnik
Copy link
Owner

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants