Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

448 make public example #450

Merged
merged 13 commits into from
Oct 11, 2024
Merged

448 make public example #450

merged 13 commits into from
Oct 11, 2024

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Jul 18, 2024

Adds a script that removes all private and protected attributes (which is used in PSyclone's kernel extraction).
Added a chapter explaining the examples to the manual, added tests for examples (triggered in CI), and added me as author.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@2d8cef7). Learn more about missing BASE report.
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #450   +/-   ##
=========================================
  Coverage          ?   92.13%           
=========================================
  Files             ?       85           
  Lines             ?    13824           
  Branches          ?        0           
=========================================
  Hits              ?    12737           
  Misses            ?     1087           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Joerg, thanks for adding to the docs and adding tests. Just a bit of tidying required.

@arporter arporter added reviewed with actions PR has been reviewed and is back with developer and removed under review labels Oct 7, 2024
@hiker
Copy link
Collaborator Author

hiker commented Oct 10, 2024

I also did some very minor pylint fixes. Strangely, black allows more than 80 characters per line, it undid some of my fixes :)

@hiker hiker added ready for review and removed reviewed with actions PR has been reviewed and is back with developer labels Oct 10, 2024
Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks for the tidying.
Yes, Black allows a slightly longer line-length because (their docs say) it resulted in a lot fewer broken lines.

@arporter arporter added the ready for merge PR is waiting on final CI checks before being merged. label Oct 11, 2024
@arporter arporter merged commit 55db863 into master Oct 11, 2024
6 checks passed
@arporter arporter deleted the 448_make_public_example branch October 11, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge PR is waiting on final CI checks before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants