-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
448 make public example #450
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
=========================================
Coverage ? 92.13%
=========================================
Files ? 85
Lines ? 13824
Branches ? 0
=========================================
Hits ? 12737
Misses ? 1087
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Joerg, thanks for adding to the docs and adding tests. Just a bit of tidying required.
I also did some very minor pylint fixes. Strangely, black allows more than 80 characters per line, it undid some of my fixes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks for the tidying.
Yes, Black allows a slightly longer line-length because (their docs say) it resulted in a lot fewer broken lines.
Adds a script that removes all private and protected attributes (which is used in PSyclone's kernel extraction).
Added a chapter explaining the examples to the manual, added tests for examples (triggered in CI), and added me as author.