Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

458 make public improvements #459

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Feb 1, 2025

Addresses #458:

  1. Leave comments in the code (to support UM-style "depends on" comments)
  2. Add example code of how to leave some definitions unchanged, used to leave "DrHook variables" like ModuleName private (these can cause compilation failures if wildcard imports are used, because a module then ends up with two conflicting definitions). The code does not change anything atm (i.e. the list of names to ignore is empty), so no change unless a user changes this definition. We do this in our LFRic-build environment for example.
  3. I also added more comments to the 'ignore_comments` docstring. Admittedly, it was actually clear and I was overthinking things, but I guess making this explicit can't hurt.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.05%. Comparing base (3bc75fe) to head (4b64bea).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   92.14%   92.05%   -0.09%     
==========================================
  Files          86       86              
  Lines       13834    13738      -96     
==========================================
- Hits        12747    12647     -100     
- Misses       1087     1091       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hiker
Copy link
Collaborator Author

hiker commented Feb 1, 2025

The CI failure is not caused by this PR:

Run actions/setup-python@v4
Installed versions
  Version 3.7 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

I could manually trigger the 3.8 run, but 3.11 keeps on getting cancelled

@arporter
Copy link
Member

arporter commented Feb 3, 2025

We had this problem with the PSyclone repo too - we had to downgrade the version of Ubuntu used for the runner in order to retain 3.7 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants