BUG: Catch keyerror for client side filter #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 111 111
Lines 4272 4272
=======================================
Hits 4252 4252
Misses 20 20 ☔ View full report in Codecov by Sentry. |
anish-mudaraddi
previously approved these changes
Jan 6, 2025
KeyErrors should be caught when a property isn't found and should return false
gmatthews20
force-pushed
the
hypervisor-fixes
branch
from
cbc0fa4 to
2b985c2
Compare
Chris-green-stfc
approved these changes
Feb 17, 2025
anish-mudaraddi
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyError should be caught when a property isn't found when using a filter and should return false for that property