Add group role mapping #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 98.19% 98.21% +0.01%
==========================================
Files 128 128
Lines 4718 4768 +50
Branches 251 251
==========================================
+ Hits 4633 4683 +50
Misses 76 76
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Renames the action to add a user with a role to a project, so it's clear which handles a group too
Adds an action to map an existing group to a project, which will be used in the next step: adding users to that group
DavidFair
force-pushed
the
Add_group_role_mapping
branch
from
4e84992 to
bbbc85a
Compare
Adds the implementation to add a user to an existing group
Adds another variation of venv to the gitignore file
As the imported name doesn't match we don't need the extra specifier of the upstream imported module, unlike the others.
This was masking the action name due to a copy-paste error
DavidFair
force-pushed
the
Add_group_role_mapping
branch
from
fdb6946 to
6f71772
Compare
A cross-domain is disallowed by OpenStack, so simplify the action to enforce this constraint in a user friendly way
Another action with a shadowing name where it was copied from an earlier action
Since we no longer make multiple calls we don't need both calls from unit testing anymore
DavidFair
force-pushed
the
Add_group_role_mapping
branch
from
b653fbf to
200b4f9
Compare
gmatthews20
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Do the project, role, group parameters take names and IDs or only one type?
| - default | ||
| - stfc | ||
| - jasmin | ||
| group_name: |
There was a problem hiding this comment.
Is this group name only or can also be ID?
Comment on lines
+122
to
+126
| mock_conn.identity.assign_project_role_to_group( | ||
| project=mock_conn.identity.find_project.return_value, | ||
| group=mock_conn.identity.find_group.return_value, | ||
| role=mock_conn.identity.find_role.return_value, | ||
| ) |
There was a problem hiding this comment.
Should this be asserting called_with?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Testing
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?