-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: add support for multiple instances of CLF #64
base: main
Are you sure you want to change the base?
Conversation
e2e5a8c
to
bc323ac
Compare
Pull Request Test Coverage Report for Build 10686914464Details
💛 - Coveralls |
0ef3985
to
9948630
Compare
9948630
to
b85ac0f
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoaoBraveCoding The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 11056133655Details
💛 - Coveralls |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue: https://issues.redhat.com/browse/LOG-6040 (there's an accompany gdoc to this PR in the issue comments)
This PR is a PoC that allows users to specify multiple CLF as
configResource
in theManagedClusterAddon
. Users should still create CLF under the namespaceopen-cluster-management-observability
. To make a CLF instance land on a namespace other thanopenshift-logging
users should annotate said CLF withmcoa/namespace
, the value in this annotation will be the namespace where the CLF instance will land.Missing:
openshift-logging
.