Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: add support for multiple instances of CLF #64

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented Sep 2, 2024

Issue: https://issues.redhat.com/browse/LOG-6040 (there's an accompany gdoc to this PR in the issue comments)

This PR is a PoC that allows users to specify multiple CLF as configResource in the ManagedClusterAddon. Users should still create CLF under the namespace open-cluster-management-observability. To make a CLF instance land on a namespace other than openshift-logging users should annotate said CLF with mcoa/namespace, the value in this annotation will be the namespace where the CLF instance will land.

Missing:

  • Update the helm chart to create arbitrary namespaces.
  • Update the helm chart to create SA & RBAC to match the different CLF instances.
  • Update the helm chart to make secrets land on the correct namespace instead of just openshift-logging.
  • Make sure we are not passing duplicated secrets to the helm chart.
  • Add tests
  • Manual Test

@coveralls
Copy link

coveralls commented Sep 3, 2024

Pull Request Test Coverage Report for Build 10686914464

Details

  • 46 of 69 (66.67%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.4%) to 56.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/logging/manifests/logging.go 38 47 80.85%
internal/logging/manifests/values.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
internal/logging/manifests/logging.go 3 83.87%
Totals Coverage Status
Change from base Build 10630428964: -1.4%
Covered Lines: 186
Relevant Lines: 328

💛 - Coveralls

Copy link

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoaoBraveCoding

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11056133655

Details

  • 37 of 63 (58.73%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 56.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/logging/manifests/logging.go 37 49 75.51%
internal/logging/manifests/values.go 0 14 0.0%
Totals Coverage Status
Change from base Build 11054546275: 0.5%
Covered Lines: 186
Relevant Lines: 328

💛 - Coveralls

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants