Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rebuilds faster #66

Closed
wants to merge 1 commit into from
Closed

Conversation

iblancasa
Copy link
Contributor

I found rebuilding is slow. We are using this structure in some projects and works well.

Signed-off-by: Israel Blancas <[email protected]>
@iblancasa iblancasa requested review from a team as code owners September 10, 2024 11:22
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10791432568

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.164%

Totals Coverage Status
Change from base Build 10770330531: 0.0%
Covered Lines: 164
Relevant Lines: 292

💛 - Coveralls

@periklis
Copy link
Collaborator

I would rather not follow this approach. It makes compatibility across different hosts harder than it should. Although the Golang compiler is decent in cross-compiling these days, I prefer to build everything in the cosy isolated container environment using the same base image across any host (linux, mac, etc.). Can it be that we miss some other long-hanging fruit here (e.g. re-arranging container file directives) that enables better utilization of container layer caching?

@iblancasa
Copy link
Contributor Author

Can it be that we miss some other long-hanging fruit here (e.g. re-arranging container file directives) that enables better utilization of container layer caching?

We had this exact conversation during one of the OpenTelemetry Operator SIG meetings and agreed to try. So far, we haven't found any issues while developing or releasing (arm64, amd64, s390x, ppc64le).

We are not shipping anything right now in this repository and we can create a separate Dockerfile or something if we find any issue in the future (which I don't think will happen, tbh). And our downstream will not be impacted.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iblancasa iblancasa closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants