Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve docker lint warning #109

Merged
merged 1 commit into from
Feb 5, 2025
Merged

chore: resolve docker lint warning #109

merged 1 commit into from
Feb 5, 2025

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Feb 5, 2025 •
edited
Loading 

  1 warning found (use docker --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)
Dockerfile:1
--------------------
   1 | >>> FROM golang:1.23-bullseye as build
   2 |     
   3 |     WORKDIR /go/src/indexing-service
--------------------

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

volmedo
volmedo approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@volmedo volmedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this! 💯

@alanshaw alanshaw merged commit 86ad802 into main Feb 5, 2025
9 checks passed
@alanshaw alanshaw deleted the chore/docker-lint-warning branch February 5, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volmedo volmedo volmedo approved these changes

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @volmedo