Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom traces in IndexingService.Query #112

Merged
merged 7 commits into from
Feb 6, 2025

Conversation

volmedo
Copy link
Member

@volmedo volmedo commented Feb 5, 2025

Wrapping up my work on custom instrumentation.

Some things can be improved but I think it will serve as an example when we come back to add more custom traces to other parts of the logic.

@volmedo volmedo self-assigned this Feb 5, 2025
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 56.09756% with 36 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/telemetry/otel.go 40.00% 9 Missing ⚠️
pkg/aws/service.go 0.00% 8 Missing ⚠️
pkg/service/providerindex/providerindex.go 61.11% 7 Missing ⚠️
pkg/service/service.go 74.07% 7 Missing ⚠️
cmd/lambda/providercache/main.go 0.00% 2 Missing ⚠️
cmd/lambda/remotesync/main.go 0.00% 2 Missing ⚠️
cmd/lambda/start.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
pkg/internal/testutil/helpers.go 100.00% <100.00%> (ø)
pkg/server/server.go 45.94% <100.00%> (+1.11%) ⬆️
cmd/lambda/start.go 0.00% <0.00%> (ø)
cmd/lambda/providercache/main.go 0.00% <0.00%> (ø)
cmd/lambda/remotesync/main.go 0.00% <0.00%> (ø)
pkg/service/providerindex/providerindex.go 35.85% <61.11%> (+2.52%) ⬆️
pkg/service/service.go 80.48% <74.07%> (-0.46%) ⬇️
pkg/aws/service.go 0.00% <0.00%> (ø)
pkg/telemetry/otel.go 11.76% <40.00%> (+11.76%) ⬆️

... and 1 file with indirect coverage changes

@volmedo volmedo merged commit 6da0a65 into main Feb 6, 2025
11 checks passed
@volmedo volmedo deleted the vic/feat/query-custom-traces branch February 6, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants