Thheinen/efs accesspoints #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update platform cookbook to support DCV on login nodes * Updated `dcv.rb` to activate dcv on the login node. * Updated `supervisord_config` to set `dcv_installed?` to be true when dcv is enabled on a login node. * Updated `parallelcluster_supervisord.conf.erb` to include `pcluster_dcv_authenticator` when dcv is configured on a login node. * Modify _dcv_common to support DCV on login node * Update cloudwatch config DCV logs to include login nodes * Allow DCV instance metadata access when enabled on login node * Rename the DCV sessionID file to be the instance hostname This is required to have multiple session files within the shared directory. * Update supervisord_config_spec to test DCV on login node * Update kitchen test and spec tests for login node dcv * Added `dcv_enabled` attribute to the login node log rotation in `kitchen.platform-config.yml`. * Updated `log_rotation_spec` to include dcv logs for login nodes. * Update CHANGELOG
Before this commit, pcluster CW config is not loaded when CW agent is running on the custom AMI, causing the lack of logs on CloudWatch. This commit appends pcluster CW config regardless of whether the CW agent is running. Therefore, CW config in the custom AMI will be preserved in addition to pcluster CW config. If there are conflicting parameters, the parameters in pcluster CW config overwrites the config from custom AMI. Signed-off-by: Hanwen <[email protected]>
`append-config` merges config, but fails when there are conflicting parameters:
```
2024/08/07 19:45:32 Under path : /metrics/metrics_collected/mem | Error : Different values are specified for mem
2024/08/07 19:45:32 Under path : /metrics/metrics_collected/disk | Error : Different values are specified for disk
2024/08/07 19:45:32 Under path : /metrics/append_dimensions | Error : Different values are specified for append_dimensions
2024/08/07 19:45:32 Under path : /metrics/metrics_collected/mem | Error : Different values are specified for mem
2024/08/07 19:45:32 Under path : /metrics/metrics_collected/disk | Error : Different values are specified for disk
2024/08/07 19:45:32 Under path : /metrics/append_dimensions | Error : Different values are specified for append_dimensions
```
`fetch-config` overwrites config.
This commit makes the code to try merging the config first. If it fails, overwrite the config.
Signed-off-by: Hanwen <[email protected]>
Signed-off-by: Thomas Heinen <[email protected]>
Signed-off-by: Thomas Heinen <[email protected]>
mapk-amazon
force-pushed
the
thheinen/efs-accesspoints
branch
from
c54273f to
572cd4b
Compare
This reverts commit 8cb540d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added missing configuration