Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Implement bare minimum modal component #18

Merged
merged 4 commits into from
May 30, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 26, 2023

Closes #8

I have created a basic Modal component based on radix UI. The styling and polishing will be done in a separate task.

📦 Published PR as canary version: 0.0.9--canary.18.0c6aa80.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@valentinpalkovic valentinpalkovic requested a review from yannbf May 26, 2023 15:03
@valentinpalkovic valentinpalkovic self-assigned this May 26, 2023
@socket-security
Copy link

socket-security bot commented May 26, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@storybook/[email protected] None +8 yannbf
@radix-ui/[email protected] None +25 benoitgrelard

@valentinpalkovic valentinpalkovic force-pushed the valentin/implement-modal branch 2 times, most recently from 694ed81 to f874b95 Compare May 30, 2023 09:39
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few minor comments

src/components/Modal/Modal.stories.tsx Outdated Show resolved Hide resolved
src/components/Modal/Modal.tsx Outdated Show resolved Hide resolved
src/components/Modal/Modal.styled.tsx Outdated Show resolved Hide resolved
src/components/Modal/Modal.styled.tsx Show resolved Hide resolved
@valentinpalkovic valentinpalkovic force-pushed the valentin/implement-modal branch from f874b95 to 7767115 Compare May 30, 2023 11:42
@valentinpalkovic valentinpalkovic merged commit 557821b into main May 30, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/implement-modal branch May 30, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project - Onboarding]: Implement Modal component (without styling)
2 participants