Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Implemented raw tooltip component #4

Closed
wants to merge 6 commits into from

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 24, 2023

Closes storybookjs/storybook#22673

What I did

I have implemented a Tooltip component without any styling. The tooltip component has some basic middleware set up, e.g.

  • shift: shifting the tooltip if there isn't enough space,
  • flip: Flip the tooltip if there isn't enough space
  • arrow: Creating a default arrow, which we can style later

I have created a Story and an interaction test to cover its functionality.

📦 Published PR as canary version: 0.0.7--canary.4.a77a4f9.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@socket-security
Copy link

socket-security bot commented May 24, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Ignoring: @storybook/[email protected], [email protected], @storybook/[email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @storybook/[email protected], @storybook/[email protected], [email protected], [email protected], @storybook/[email protected], @babel/[email protected], [email protected], [email protected]

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@storybook/[email protected] None +21 yannbf
@floating-ui/[email protected] environment +5 atomiks
@types/[email protected] None +0 types
[email protected] None +183 shilman
⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
@storybook/[email protected] 0.0.14-next.1...0.0.14-next.2 None +15/-24 yannbf
[email protected] 10.43.0...10.46.0 None +11/-17 alisowski
[email protected] 6.6.3...6.7.0 eval +30/-29 egoist
[email protected] 2.8.4...2.8.8 None +0/-0 prettier-bot
@storybook/[email protected] 7.0.0...7.0.17 None +50/-68 shilman
@storybook/[email protected] 7.0.0...7.0.17 None +74/-97 shilman
@storybook/[email protected] 7.0.0...7.0.17 None +38/-51 shilman
@storybook/[email protected] 7.0.0...7.0.17 None +12/-25 shilman
@storybook/[email protected] 7.0.0...7.0.17 None +67/-101 shilman

🚮 Removed packages: @types/[email protected], [email protected]

@valentinpalkovic
Copy link
Contributor Author

@SocketSecurity ignore-all

@valentinpalkovic valentinpalkovic force-pushed the valentin/add-raw-tooltip branch from 25d82d6 to 8f8ab90 Compare May 24, 2023 18:47
@valentinpalkovic valentinpalkovic requested a review from yannbf May 24, 2023 18:50
@valentinpalkovic
Copy link
Contributor Author

Closing in favor of #5, because, react-joyride already has a tooltip component included, which makes this task obsolete.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project - Onboarding]: Implement Tooltip functionality (without styling)
2 participants