This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
generated from storybookjs/addon-kit
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
@SocketSecurity ignore-all |
valentinpalkovic
force-pushed
the
valentin/add-raw-tooltip
branch
from
May 24, 2023 18:47
25d82d6
to
8f8ab90
Compare
yannbf
approved these changes
May 25, 2023
Closing in favor of #5, because, react-joyride already has a tooltip component included, which makes this task obsolete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes storybookjs/storybook#22673
What I did
I have implemented a Tooltip component without any styling. The tooltip component has some basic middleware set up, e.g.
shift
: shifting the tooltip if there isn't enough space,flip
: Flip the tooltip if there isn't enough spacearrow
: Creating a default arrow, which we can style laterI have created a Story and an interaction test to cover its functionality.
📦 Published PR as canary version:
0.0.7--canary.4.a77a4f9.0
✨ Test out this PR locally via: