Merge branch 'next' into norbert/downgrade-playwright

.github/workflows/cron-weekly.yml

@@ -16,4 +16,9 @@ jobs:
           use-quiet-mode: 'yes'
           # output full HTTP info for broken links
           use-verbose-mode: 'yes'
-          config-file: '.github/workflows/markdown-link-check-config.json'
+          config-file: '.github/workflows/markdown-link-check-config.json'   
+      # Notify to Discord channel on failure
+      - name: Send Discord Notification
+        if: failure() # Only run this step if previous steps failed
+        run: |
+          curl -H "Content-Type: application/json" -X POST -d '{"content":"The Markdown Links Check workflow has failed in the repository: [storybook]"}' ${{ secrets.DISCORD_MONITORING_URL }}

MIGRATION.md

@@ -1070,7 +1070,7 @@ Example:
 import { addons, types } from "@storybook/manager-api";
 
 addons.register("my-addon", () => {
-  addons.add("my-addon/panel", {
+  addons.add("my-addon/tab", {
     type: types.TAB,
     title: "My Addon",
     render: () => <div>Hello World</div>,
@@ -1092,7 +1092,7 @@ addons.register("my-addon", () => {
   addons.add("my-addon/tool", {
     type: types.TOOL,
     title: "My Addon",
-    match: ({ tabId }) => tabId === "my-addon/panel",
+    match: ({ tabId }) => tabId === "my-addon/tab",
     render: () => <div>👀</div>,
   });
 });

code/e2e-tests/addon-docs.spec.ts

@@ -34,7 +34,8 @@ test.describe('addon-docs', () => {
     await expect(anotherStory).toContainText('Another button, just to show multiple stories');
   });
 
-  test('should show source=code view for stories', async ({ page }) => {
+  // FIXME - get rid of the flake
+  test.skip('should show source=code view for stories', async ({ page }) => {
     const skipped = [
       // SSv6 does not render stories in the correct order in our sandboxes
       'internal\\/ssv6',

code/e2e-tests/tags.spec.ts

@@ -3,7 +3,8 @@ import { SbPage } from './util';
 
 const storybookUrl = process.env.STORYBOOK_URL || 'http://localhost:8001';
 
-test.describe('tags', () => {
+// FIXME - get rid of the flake
+test.describe.skip('tags', () => {
   test.beforeEach(async ({ page }) => {
     await page.goto(storybookUrl);
     await new SbPage(page).waitUntilLoaded();

code/lib/cli/package.json

@@ -96,7 +96,7 @@
     "@types/cross-spawn": "^6.0.2",
     "@types/prompts": "^2.0.9",
     "@types/util-deprecate": "^1.0.0",
-    "boxen": "^5.1.2",
+    "boxen": "^7.1.1",
     "slash": "^5.0.0",
     "strip-json-comments": "^3.1.1",
     "typescript": "^5.3.2"

code/lib/cli/src/automigrate/fixes/react-docgen.ts

@@ -26,11 +26,12 @@ export const reactDocgen: Fix<Options> = {
       but "typescript.reactDocgen" is unset.
       
       In Storybook 8.0, we changed the default React docgen analysis from 
-      "react-docgen-typescript" to "react-docgen", which dramatically faster
-      but doesn't handle all TypeScript constructs.
-
-      We can update your config to continue to use "react-docgen-typescript",
-      though we recommend giving "react-docgen" for a much faster dev experience.
+      "react-docgen-typescript" to "react-docgen". We recommend "react-docgen"
+      for most projects, since it is dramatically faster. However, it doesn't
+      handle all TypeScript constructs, and may generate different results
+      than "react-docgen-typescript".
+      
+      Should we update your config to continue to use "react-docgen-typescript"?
 
       https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#react-docgen-component-analysis-by-default
     `;

code/lib/cli/src/generators/baseGenerator.ts

@@ -196,7 +196,7 @@ export async function baseGenerator(
   );
 
   const {
-    extraAddons: extraAddonPackages,
+    extraAddons: extraAddonPackages = [],
     extraPackages,
     staticDir,
     addScripts,
@@ -222,21 +222,23 @@ export async function baseGenerator(
         })
       : extraAddonPackages;
 
-  // added to main.js
-  const addons = [
+  extraAddonsToInstall.push(
     '@storybook/addon-links',
     '@storybook/addon-essentials',
+    '@chromatic-com/storybook@^1'
+  );
+
+  // added to main.js
+  const addons = [
     ...(compiler ? [`@storybook/addon-webpack5-compiler-${compiler}`] : []),
-    ...stripVersions(extraAddonsToInstall || []),
+    ...stripVersions(extraAddonsToInstall),
   ].filter(Boolean);
 
   // added to package.json
   const addonPackages = [
-    '@storybook/addon-links',
-    '@storybook/addon-essentials',
     '@storybook/blocks',
     ...(compiler ? [`@storybook/addon-webpack5-compiler-${compiler}`] : []),
-    ...(extraAddonsToInstall || []),
+    ...extraAddonsToInstall,
   ].filter(Boolean);
 
   // TODO: migrate template stories in solid and qwik to use @storybook/test

code/lib/core-server/package.json

@@ -104,7 +104,7 @@
     "@types/ip": "^1.1.0",
     "@types/node-fetch": "^2.5.7",
     "@types/ws": "^8",
-    "boxen": "^5.1.2",
+    "boxen": "^7.1.1",
     "node-fetch": "^3.3.1",
     "slash": "^5.0.0",
     "typescript": "^5.3.2"