Skip to content

Commit

Permalink
Test out empty init circle job
Browse files Browse the repository at this point in the history
  • Loading branch information
Shaun Lloyd committed Nov 29, 2023
1 parent 07790cb commit 3b8cdc4
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 42 deletions.
79 changes: 42 additions & 37 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -494,10 +494,15 @@ jobs:
command: mkdir empty-<< parameters.template >> && cd empty-<< parameters.template >>
- run:
name: Run storybook init
command: yarn storybook init
command: node ../storybook/code/lib/cli/bin.js init --packageManager << parameters.packageManager >>
environment:
STORYBOOK_PACKAGE_MANAGER: << parameters.packageManager >>
CI: true
STORYBOOK_INIT_EMPTY_TYPE: << parameters.template >>
- run:
name: Run Smoke test
command: node ../storybook/code/lib/cli/bin.js dev --smoke-test
environment:
CI: true

workflows:
docs:
Expand Down Expand Up @@ -636,45 +641,45 @@ workflows:
- script-checks:
requires:
- build
- chromatic-internal-storybooks:
requires:
- build
- create-sandboxes:
parallelism: 36
requires:
- build
# - chromatic-internal-storybooks:
# requires:
# - build
# - create-sandboxes:
# parallelism: 36
# requires:
# - build
# - smoke-test-sandboxes: # disabled for now
# requires:
# - create-sandboxes
- build-sandboxes:
parallelism: 36
requires:
- create-sandboxes
- chromatic-sandboxes:
parallelism: 33
requires:
- build-sandboxes
- e2e-production:
parallelism: 31
requires:
- build-sandboxes
- e2e-dev:
parallelism: 2
requires:
- create-sandboxes
- test-runner-production:
parallelism: 31
requires:
- build-sandboxes
# TODO: Uncomment when ready to test
# - test-empty-init:
# parallelism: 15
# - build-sandboxes:
# parallelism: 36
# requires:
# - build
# matrix:
# parameters:
# packageManager: [yarn2],
# template: ["react-vite-ts", "nextjs-ts", "vue-vite-ts", "angular-cli", "lit-vite-ts"]
# - create-sandboxes
# - chromatic-sandboxes:
# parallelism: 33
# requires:
# - build-sandboxes
# - e2e-production:
# parallelism: 31
# requires:
# - build-sandboxes
# - e2e-dev:
# parallelism: 2
# requires:
# - create-sandboxes
# - test-runner-production:
# parallelism: 31
# requires:
# - build-sandboxes
# TODO: Uncomment when ready to test
- test-empty-init:
parallelism: 5
requires:
- build
matrix:
parameters:
packageManager: [yarn2],
template: ["react-vite-ts", "nextjs-ts", "vue-vite-ts", "angular-cli", "lit-vite-ts"]

# TODO: reenable once we find out the source of flakyness
# - test-runner-dev:
Expand Down
6 changes: 1 addition & 5 deletions code/lib/cli/src/generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,7 @@ command('init')
.description('Initialize Storybook into your project.')
.option('-f --force', 'Force add Storybook')
.option('-s --skip-install', 'Skip installing deps')
.option(
'--package-manager <npm|pnpm|yarn1|yarn2>',
'Force package manager for installing deps',
process.env.STORYBOOK_PACKAGE_MANAGER
)
.option('--package-manager <npm|pnpm|yarn1|yarn2>', 'Force package manager for installing deps')
.option('-N --use-npm', 'Use npm to install deps (deprecated)')
.option('--use-pnp', 'Enable pnp mode for Yarn 2+')
.option('-p --parser <babel | babylon | flow | ts | tsx>', 'jscodeshift parser')
Expand Down

0 comments on commit 3b8cdc4

Please sign in to comment.