Merge pull request #25196 from storybookjs/norbert/not-add-react-init

CLI: No longer add react in init
storybookjs · Dec 18, 2023 · ce5d8a1 · ce5d8a1
2 parents 0096e7b + d17d493
commit ce5d8a1
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 149 deletions.
diff --git a/code/lib/cli/src/automigrate/fixes/add-react.test.ts b/code/lib/cli/src/automigrate/fixes/add-react.test.ts
diff --git a/code/lib/cli/src/automigrate/fixes/add-react.ts b/code/lib/cli/src/automigrate/fixes/add-react.ts
diff --git a/code/lib/cli/src/automigrate/fixes/index.ts b/code/lib/cli/src/automigrate/fixes/index.ts
@@ -12,7 +12,6 @@ import { newFrameworks } from './new-frameworks';
 import { removedGlobalClientAPIs } from './remove-global-client-apis';
 import { mdx1to2 } from './mdx-1-to-2';
 import { autodocsTrue } from './autodocs-true';
-import { addReact } from './add-react';
 import { nodeJsRequirement } from './nodejs-requirement';
 import { missingBabelRc } from './missing-babelrc';
 import { angularBuilders } from './angular-builders';
@@ -38,7 +37,6 @@ export const allFixes: Fix[] = [
   mdx1to2,
   mdxgfm,
   autodocsTrue,
-  addReact,
   missingBabelRc,
   angularBuildersMultiproject,
   angularBuilders,

diff --git a/code/lib/cli/src/generators/baseGenerator.ts b/code/lib/cli/src/generators/baseGenerator.ts
@@ -282,15 +282,6 @@ export async function baseGenerator(
     Object.keys({ ...packageJson.dependencies, ...packageJson.devDependencies })
   );
 
-  if (!installedDependencies.has('react')) {
-    // we add these here because they are required by addon-essentials > addon-docs
-    addonPackages.push('react');
-  }
-  if (!installedDependencies.has('react-dom')) {
-    // we add these here because they are required by addon-essentials > addon-docs
-    addonPackages.push('react-dom');
-  }
-
   // TODO: We need to start supporting this at some point
   if (type === 'renderer') {
     throw new Error(