Merge pull request #24466 from storybookjs/valentin/angular-add-sourc…

…e-map-support Angular: Add source-map option to builder
storybookjs · Oct 19, 2023 · d996aaf · d996aaf
2 parents a5a7747 + 8fdfcf9
commit d996aaf
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/code/frameworks/angular/src/builders/build-storybook/index.ts b/code/frameworks/angular/src/builders/build-storybook/index.ts
@@ -21,6 +21,7 @@ import { addToGlobalContext } from '@storybook/telemetry';
 import { buildStaticStandalone, withTelemetry } from '@storybook/core-server';
 import {
   AssetPattern,
+  SourceMapUnion,
   StyleElement,
 } from '@angular-devkit/build-angular/src/builders/browser/schema';
 import { StandaloneOptions } from '../utils/standalone-options';
@@ -39,6 +40,7 @@ export type StorybookBuilderOptions = JsonObject & {
   styles?: StyleElement[];
   stylePreprocessorOptions?: StylePreprocessorOptions;
   assets?: AssetPattern[];
+  sourceMap?: SourceMapUnion;
 } & Pick<
     // makes sure the option exists
     CLIOptions,
@@ -92,6 +94,7 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (
         disableTelemetry,
         assets,
         previewUrl,
+        sourceMap = false,
       } = options;
 
       const standaloneOptions: StandaloneBuildOptions = {
@@ -109,6 +112,7 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (
           ...(stylePreprocessorOptions ? { stylePreprocessorOptions } : {}),
           ...(styles ? { styles } : {}),
           ...(assets ? { assets } : {}),
+          sourceMap,
         },
         tsConfig,
         webpackStatsJson,

diff --git a/code/frameworks/angular/src/builders/build-storybook/schema.json b/code/frameworks/angular/src/builders/build-storybook/schema.json
@@ -101,6 +101,11 @@
       "items": {
         "$ref": "#/definitions/assetPattern"
       }
+    },
+    "sourceMap": {
+      "type": ["boolean", "object"],
+      "description": "Configure sourcemaps. See: https://angular.io/guide/workspace-config#source-map-configuration",
+      "default": false
     }
   },
   "additionalProperties": false,

diff --git a/code/frameworks/angular/src/builders/start-storybook/index.ts b/code/frameworks/angular/src/builders/start-storybook/index.ts
@@ -19,6 +19,7 @@ import { addToGlobalContext } from '@storybook/telemetry';
 import { buildDevStandalone, withTelemetry } from '@storybook/core-server';
 import {
   AssetPattern,
+  SourceMapUnion,
   StyleElement,
 } from '@angular-devkit/build-angular/src/builders/browser/schema';
 import { StandaloneOptions } from '../utils/standalone-options';
@@ -36,6 +37,7 @@ export type StorybookBuilderOptions = JsonObject & {
   styles?: StyleElement[];
   stylePreprocessorOptions?: StylePreprocessorOptions;
   assets?: AssetPattern[];
+  sourceMap?: SourceMapUnion;
 } & Pick<
     // makes sure the option exists
     CLIOptions,
@@ -111,6 +113,7 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (options, cont
         loglevel,
         webpackStatsJson,
         previewUrl,
+        sourceMap = false,
       } = options;
 
       const standaloneOptions: StandaloneOptions = {
@@ -134,6 +137,7 @@ const commandBuilder: BuilderHandlerFn<StorybookBuilderOptions> = (options, cont
           ...(stylePreprocessorOptions ? { stylePreprocessorOptions } : {}),
           ...(styles ? { styles } : {}),
           ...(assets ? { assets } : {}),
+          sourceMap,
         },
         tsConfig,
         initialPath,

diff --git a/code/frameworks/angular/src/builders/start-storybook/schema.json b/code/frameworks/angular/src/builders/start-storybook/schema.json
@@ -142,6 +142,11 @@
       "type": "string",
       "description": "Controls level of logging during build. Can be one of: [silly, verbose, info (default), warn, error, silent].",
       "pattern": "(silly|verbose|info|warn|silent)"
+    },
+    "sourceMap": {
+      "type": ["boolean", "object"],
+      "description": "Configure sourcemaps. See: https://angular.io/guide/workspace-config#source-map-configuration",
+      "default": false
     }
   },
   "additionalProperties": false,

diff --git a/code/frameworks/angular/src/builders/utils/standalone-options.ts b/code/frameworks/angular/src/builders/utils/standalone-options.ts
@@ -1,6 +1,7 @@
 import { BuilderContext } from '@angular-devkit/architect';
 import {
   AssetPattern,
+  SourceMapUnion,
   StyleElement,
   StylePreprocessorOptions,
 } from '@angular-devkit/build-angular/src/builders/browser/schema';
@@ -16,6 +17,7 @@ export type StandaloneOptions = CLIOptions &
       styles?: StyleElement[];
       stylePreprocessorOptions?: StylePreprocessorOptions;
       assets?: AssetPattern[];
+      sourceMap?: SourceMapUnion;
     };
     angularBuilderContext?: BuilderContext | null;
     tsConfig?: string;