Skip to content

Commit

Permalink
Merge pull request #29832 from storybookjs/yann/disable-cra-sandboxes
Browse files Browse the repository at this point in the history
Build: Temporarily disable CRA sandboxes
  • Loading branch information
yannbf authored Dec 6, 2024
2 parents 052f6ce + 32c8e43 commit ed4fb2d
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
36 changes: 18 additions & 18 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -836,27 +836,27 @@ workflows:
requires:
- unit-tests
- create-sandboxes:
parallelism: 14
parallelism: 13
requires:
- build
- build-sandboxes:
parallelism: 14
parallelism: 13
requires:
- create-sandboxes
- chromatic-sandboxes:
parallelism: 11
parallelism: 10
requires:
- build-sandboxes
- e2e-production:
parallelism: 9
parallelism: 8
requires:
- build-sandboxes
- e2e-dev:
parallelism: 2
parallelism: 1
requires:
- create-sandboxes
- test-runner-production:
parallelism: 9
parallelism: 8
requires:
- build-sandboxes
- vitest-integration:
Expand Down Expand Up @@ -912,27 +912,27 @@ workflows:
requires:
- unit-tests
- create-sandboxes:
parallelism: 20
parallelism: 19
requires:
- build
- build-sandboxes:
parallelism: 20
parallelism: 19
requires:
- create-sandboxes
- chromatic-sandboxes:
parallelism: 17
parallelism: 16
requires:
- build-sandboxes
- e2e-production:
parallelism: 15
parallelism: 14
requires:
- build-sandboxes
- e2e-dev:
parallelism: 2
parallelism: 1
requires:
- create-sandboxes
- test-runner-production:
parallelism: 15
parallelism: 14
requires:
- build-sandboxes
- vitest-integration:
Expand Down Expand Up @@ -986,30 +986,30 @@ workflows:
requires:
- build
- create-sandboxes:
parallelism: 38
parallelism: 36
requires:
- build
# - smoke-test-sandboxes: # disabled for now
# requires:
# - create-sandboxes
- build-sandboxes:
parallelism: 38
parallelism: 36
requires:
- create-sandboxes
- chromatic-sandboxes:
parallelism: 35
parallelism: 33
requires:
- build-sandboxes
- e2e-production:
parallelism: 33
parallelism: 31
requires:
- build-sandboxes
- e2e-dev:
parallelism: 2
parallelism: 1
requires:
- create-sandboxes
- test-runner-production:
parallelism: 33
parallelism: 31
requires:
- build-sandboxes
- vitest-integration:
Expand Down
8 changes: 4 additions & 4 deletions code/lib/cli-storybook/src/sandbox-templates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ const baseTemplates = {
extraDependencies: ['server-only', 'prop-types'],
},
skipTasks: ['e2e-tests-dev', 'bench', 'vitest-integration'],
inDevelopment: true,
},
'nextjs/default-ts': {
name: 'Next.js Latest (Webpack | TypeScript)',
Expand Down Expand Up @@ -229,7 +228,6 @@ const baseTemplates = {
'prop-types',
],
},
inDevelopment: true,
skipTasks: ['e2e-tests-dev', 'bench'],
},
'experimental-nextjs-vite/default-ts': {
Expand Down Expand Up @@ -806,7 +804,8 @@ export const allTemplates: Record<TemplateKey, Template> = {
};

export const normal: TemplateKey[] = [
'cra/default-ts',
// TODO: Add this back once we resolve the React 19 issues
// 'cra/default-ts',
'react-vite/default-ts',
'angular-cli/default-ts',
'vue3-vite/default-ts',
Expand Down Expand Up @@ -836,7 +835,8 @@ export const merged: TemplateKey[] = [
export const daily: TemplateKey[] = [
...merged,
'angular-cli/prerelease',
'cra/default-js',
// TODO: Add this back once we resolve the React 19 issues
// 'cra/default-js',
'react-vite/default-js',
'react-vite/prerelease-ts',
'react-webpack/prerelease-ts',
Expand Down

0 comments on commit ed4fb2d

Please sign in to comment.