-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry: Count onboarding stories #23092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
reviewed
Jun 15, 2023
yannbf
reviewed
Jun 15, 2023
shilman
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Jun 15, 2023
yannbf
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6 tasks
JReinhold
pushed a commit
that referenced
this pull request
Jun 15, 2023
…tories Telemetry: Count onboarding stories (cherry picked from commit 9f151fc)
JReinhold
pushed a commit
that referenced
this pull request
Jun 15, 2023
…tories Telemetry: Count onboarding stories (cherry picked from commit 9f151fc)
Merged
9 tasks
JReinhold
pushed a commit
that referenced
this pull request
Jun 16, 2023
…tories Telemetry: Count onboarding stories (cherry picked from commit 9f151fc)
JReinhold
pushed a commit
that referenced
this pull request
Jun 17, 2023
…tories Telemetry: Count onboarding stories (cherry picked from commit 9f151fc)
This was referenced Jun 17, 2023
Merged
Merged
shilman
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Jun 27, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
User-facing maintenance tasks
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
telemetry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N/A
What I did
Add onboarding story count per #22558
How to test
See attached tests, or run a sandbox with
STORYBOOK_TELEMETRY_DEBUG=1
and add aWarning
story to the Button.