Ember: Allow ember v5 as peer deps

[gossi]

Closes #25385

Thanks to #23435 which allowed to use sb8 with ember again, the ember community can happily go into experimentation with storybook and they do. As ember's major is already v5, the existing peer dependency produce nasty installation errors. That little fix takes that off and allows sb cli to run as designed, wo/ this package manager whoopsie.

What I did

Expand the peer dep range.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

There is no matrix to testing for ember versions, so I must say no to these.

Manual testing

I tested it locally and thanks to #23435 (which enabled ember v5), this is working. I tested it with my OSS design system (currently change is only local as it is in experimentation ;-) so I cannot link the related code).

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[gossi]

Last time I contributed was on v6 😂 Tooling has changed, I actually did the PR on github itself. It may be that it requires an update to the yarn.lock file.

I checked the contributing docs, I was hoping to run yarn install (which is not a thing) but I dunno what I would need to do then ?!?

[veelci]

@shilman Is there any chance that Ember 5 support could make it in the 8.0.0 release?

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3843fef. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build -c production --parallel=8

---

Sent with 💌 from NxCloud.

[gossi]

I tried working on this PR and keep it updated with upstream branches. From my side, I consider this good but CI seems not to be happy with it:

• DangerJS complains about missing tokens?
• circle CI ain't run for whatever reason?

@shilman can you take a look? And maybe also let me know, how I can trigger this myself in the future?

[JReinhold]

@gossi would this fix #26643 too?

[gossi]

@JReinhold no, it's not. This little "bug" helps with installation, some package managers are configured to stop or report "breakage", when peerDeps aren't fulfilled.

[tysonstewart]

What can we do to help get this PR merged? We've attempted to fork the repo and apply the change (thank you @gossi!), but the complexity of this repo has made it extremely difficult to use our fork rather than the official version.

[er-lim]

We are also having the same problem when migrating our project using storybook to Ember 5. Thanks @gossi for the fix !

There are conflicts on the PR and, by reading comments, CI seems to not be triggered on the last commit.
What can we do to make this PR progress ?