Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added a small bit of code to the addon/viewport that adds a data attribute to the
iframe body
element (containing#storybook-root
) calleddata-storybook-viewport-id
. This lets you define viewport specific styles in.storybook/preview.css
such asCurrently only the height and width of the viewport can be adjusted, but with this change if you want to add other attributes you can define them in CSS without changing the API.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn storybook:ui
incode\
document.querySelector('iframe[data-is-storybook="true"]').contentDocument.querySelector('body').dataset.storybookViewportId