Core: Disable SidebarContextMenu in static builds #29743
Conversation
ndelangen
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0768cd1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
…bookjs/storybook into norbert/no-context-in-prod
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -22,6 +22,7 @@ import { DocsPageWrapper } from '../lib/blocks/src/components'; | |||
| import { isChromatic } from './isChromatic'; | |||
|
|
|||
| const { document } = global; | |||
| globalThis.CONFIG_TYPE = 'DEVELOPMENT'; | |||
There was a problem hiding this comment.
style: setting CONFIG_TYPE globally could affect other parts of the codebase that rely on this value. Consider using an environment variable or configuration option instead
| const { document } = global; | ||
| globalThis.CONFIG_TYPE = 'DEVELOPMENT'; |
There was a problem hiding this comment.
logic: this change forces development mode for all preview environments, which may have unintended consequences for production builds
| if (globalThis.CONFIG_TYPE !== 'DEVELOPMENT') { | ||
| return empty; | ||
| } |
There was a problem hiding this comment.
style: Consider using process.env.NODE_ENV instead of globalThis.CONFIG_TYPE for more reliable environment detection
ndelangen
added
the
needs qa
yannbf
removed
the
needs qa
Closes #29741
What I did
I disabled the SidebarContextMenu in static builds
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
QA should include generating a static storybook, and verifying the context menu are not available
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Implements conditional rendering of the SidebarContextMenu to prevent the focused test run tooltip from appearing in static/production builds of Storybook.
code/.storybook/preview.tsxto setglobalThis.CONFIG_TYPE = 'DEVELOPMENT'code/core/src/manager/components/sidebar/ContextMenu.tsxto disable menu in production builds