Release: Prerelease alpha 8.5.0-alpha.21 #30017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…y more appropriate
…opping Vitest: Correctly stop Storybook when Vitest closes
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| logger.verbose('Stopping Storybook process'); | ||
| await new Promise<void>((resolve, reject) => { | ||
| // Storybook starts multiple child processes, so we need to kill the whole tree | ||
| treeKill(storybookProcess.pid, 'SIGTERM', (error) => { |
There was a problem hiding this comment.
style: Consider adding a timeout to the treeKill operation in case it hangs
| // Storybook starts multiple child processes, so we need to kill the whole tree | ||
| treeKill(storybookProcess.pid, 'SIGTERM', (error) => { | ||
| if (error) { | ||
| logger.error('Failed to stop Storybook process:'); |
There was a problem hiding this comment.
logic: The error message is incomplete - it should include the actual error details from the callback
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
aefe495 to
d119317
Compare
…r-older-typescript-configurations Addon A11y: Add typesVersions support for TypeScript definitions in a11y package
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
d119317 to
0503851
Compare
Build: Improve task command and error message
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
0503851 to
dfedc08
Compare
…sper/a11y-postinstall
Core: Fix bundling of React
…-always-running Addon A11y: Refactor environment variable handling for Vitest integration
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
e153d04 to
dfd5c3c
Compare
…-while-running Addon A11y: Update accessibility status handling in TestProviderRender
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
dfd5c3c to
4922d36
Compare
Co-authored-by: Jeppe Reinhold <[email protected]> Co-authored-by: Jeppe Reinhold <[email protected]>
…orybook into norbert/fix-29785
Addon A11y: Run the a11y automigration on postInstall
Addon Onboarding: Prebundle react-confetti
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
4922d36 to
09d9ce1
Compare
…er-toggle-state-in-main-testing-module Addon Test: Show sub test provider toggle state in main testing module
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
09d9ce1 to
5f57172
Compare
TestAddon: Wrap sub-paths exported with `require.resolve`
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
5f57172 to
829111a
Compare
valentinpalkovic
added
freeze
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2de3b7a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
storybook-bot
force-pushed
the
version-non-patch-from-8.5.0-alpha.20
branch
from
829111a to
2de3b7a
Compare
github-actions
bot
changed the title
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 59 | 59 | 0 |
| Self size | 45 KB | 411 KB | 🚨 +366 KB 🚨 |
| Dependency size | 13.46 MB | 13.46 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-onboarding
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 2 | 0 | 🎉 -2 🎉 |
| Self size | 216 KB | 235 KB | 🚨 +19 KB 🚨 |
| Dependency size | 235 KB | 670 B | 🎉 -235 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 110 | 111 | 🚨 +1 🚨 |
| Self size | 16 KB | 16 KB | 0 B |
| Dependency size | 42.58 MB | 42.59 MB | 🚨 +12 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/preset-vue3-webpack
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 368 | 369 | 🚨 +1 🚨 |
| Self size | 9 KB | 9 KB | 0 B |
| Dependency size | 45.14 MB | 45.16 MB | 🚨 +16 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
8.5.0-alpha.20to8.5.0-alpha.21.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.21.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:require.resolve#30026If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.21
require.resolve- #30026, thanks @ndelangen!