Skip to content

(WIP) [Highlighter] - performance improvements #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

marvinoffers
Copy link
Contributor

@marvinoffers marvinoffers commented Apr 15, 2025

  • moves components to reduce re-renders
  • other performance improvements
  • change structure of how highlighted streams are stored in localstorage
    (so testing this branch and then switching to an older branch will cause the highlighted streams to disappear)

@@ -303,8 +297,43 @@ export class HighlighterService extends PersistentStatefulService<IHighlighterSt
return new HighlighterViews(this.state);
}

private async migrateHighlightedStreamsToDictionary() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant