Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth tutorials #1228

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Auth tutorials #1228

wants to merge 7 commits into from

Conversation

sfc-gh-dmatthews
Copy link
Contributor

@sfc-gh-dmatthews sfc-gh-dmatthews commented Feb 7, 2025

📚 Context

Add Google Auth tutorial
Add Microsoft Entra tutorial

Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-dmatthews sfc-gh-dmatthews changed the title Auth tutorials Google auth tutorial Feb 7, 2025
@sfc-gh-dmatthews sfc-gh-dmatthews changed the title Google auth tutorial Auth tutorials Feb 8, 2025
@kajarenc
Copy link
Collaborator

kajarenc commented Feb 9, 2025

LGTM 👍

I think for some moment (probably for the Okta tutorial it makes more sense, but could be good for Microsoft Entra too) it could be a good idea to explain the client_kwargs option in the secrets and communicate that we use the default
scope="openid profile email" and prompt="select_account", but it could be overridden by the user.

I know this information is already included in the st.login documentation itself, but could be a good idea to highlight it in one of the upcoming tutorials

@sfc-gh-dmatthews
Copy link
Contributor Author

I think for some moment (probably for the Okta tutorial it makes more sense, but could be good for Microsoft Entra too) it could be a good idea to explain the client_kwargs option in the secrets and communicate that we use the default
scope="openid profile email" and prompt="select_account", but it could be overridden by the user.

I'll publish the tutorials without this to get them out. I plan on including it for Auth0 since it is more likely to have impact and they have a complete documentation page outlining different options that I can't find for others. I can circle back to Microsoft and add it as an optional extension.

Copy link
Contributor

@sfc-gh-mfaulkner sfc-gh-mfaulkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Google and MSFT files had many similarities, so I tried to edit them similarly. Let me know if I created any inconsistencies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants