Update $FlowFixMees #806
Update $FlowFixMees #806
Conversation
| PortExport.styles = styles | ||
|
|
||
| export default PortExport | ||
| export default (React.memo(Port): ComponentType<Props>) |
There was a problem hiding this comment.
General rule for things like memo or forwardRef is that the exporter has to let others know what kind of thing they're importing. ComponentType<Props> is fine for most cases.
| @@ -78,7 +80,7 @@ class HistoryView extends Component<Props, State> { | |||
| } | |||
|
|
|||
| mounted = false | |||
| fileUploadRef = React.createRef() | |||
| fileUploadRef: Ref<Dropzone> = React.createRef() | |||
There was a problem hiding this comment.
This one is interesting. We have to declare what does FileUpload assign to this ref. In this case it's a Dropzone instance.
app/src/editor/canvas/components/Resizable/resizeable.stories.jsx
Outdated
Show resolved
Hide resolved
app/src/marketplace/components/ProductPage/CollapsedText/collapsedText.stories.jsx
Show resolved
Hide resolved
|
|
||
| if (!resend) { | ||
| delete options.resend | ||
| } |
There was a problem hiding this comment.
sure, this is probably clearer anyway
| @@ -122,7 +124,7 @@ const StreamList = () => { | |||
| setSort, | |||
| resetFilter, | |||
| } = useFilterSort(sortOptions) | |||
| const [dialogTargetStream, setDialogTargetStream] = useState(undefined) | |||
| const [dialogTargetStream, setDialogTargetStream]: TargetStreamSetter = useState(null) | |||
There was a problem hiding this comment.
I wish we could just stop using null but I see the rest of this code uses null so 🤷♀
| @@ -155,6 +155,7 @@ export function SecurityIcon({ | |||
| } | |||
|
|
|||
| export function SecurityView(props: Props) { | |||
| // $FlowFixMe `updateEditStream` not in OwnProps or StateProps. | |||
There was a problem hiding this comment.
@mondoreale any idea what the problem is here
There was a problem hiding this comment.
No idea. That's the main "wtf" here. I left those out.
| ) | ||
| .reduce((result, transaction: TransactionEntity) => ( | ||
| result.includes(transaction.productId) ? result : [...result, (transaction.productId || '')] | ||
| ), []) |
There was a problem hiding this comment.
Not important really but this reduce should probably go away in favour of using aSet to do the deduping:
Array.from(new Set(productsToFetch.map(({ productId }) => productId))
I guess most of them explanations are gonna be “wtf?” or “Yeah, flow, very funny!”. Still, better than nothing!
The react-hooks deps likes this one, actually. eslint by itself doesn’t care.
mondoreale
force-pushed
the
update-flowfixmees
branch
from
853e4f1 to
bb5b70d
Compare
Another one of these. As I promised, a whole bunch of
$FlowFixMe's gone. The ones that stayed are… well, even I don't know wtf doesflowwant. 🐽Also, I added an eslint rule for
$FlowFixMecomments. They need explanation from now on. A simple// $FlowFixMewon't do. Hope that's helpful.