Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when the bitstream contains a CRA and following RASL pictures #131

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,12 @@ test_script:
- build\dec265.exe -t 4 -q -c -f 100 libde265-data\RandomAccess\paris-ra-wpp.bin

artifacts:
- path: build
- path: libde265/Release/libde265.dll

deploy:
provider: GitHub
auth_token:
secure: boWJ9aVfVBpOkBGzWF5yS5/Os3eDUjFfziOY04+LNA+7v+PnMFBtHeMJe2PjK4gm
artifact: libde265/Release/libde265.dll
on:
appveyor_repo_tag: true # deploy on tag push only
7 changes: 7 additions & 0 deletions libde265/decctx.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2039,6 +2039,8 @@ bool decoder_context::process_slice_segment_header(slice_segment_header* hdr,
NoRaslOutputFlag)
{
img->PicOutputFlag = false;
// This is a RASL but we are not going to output (decode) RASLs.
return false;
}
else
{
Expand All @@ -2064,6 +2066,11 @@ bool decoder_context::process_slice_segment_header(slice_segment_header* hdr,
first_decoded_picture = false;
}
else {
if (isRASL(nal_unit_type) && NoRaslOutputFlag) {
// Not the first slice, a RASL, and we are not outputting (decoding) RASLS.
return false;
}

// claims to be not the first slice, but there is no active image available

if (img == NULL) {
Expand Down