-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rworkflows #1480
base: master
Are you sure you want to change the base?
Add rworkflows #1480
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1480 +/- ##
=========================================
Coverage ? 16.97%
=========================================
Files ? 24
Lines ? 6179
Branches ? 0
=========================================
Hits ? 1049
Misses ? 5130
Partials ? 0 |
Hey @timoast I noticed you're experiencing the same errors as I am regarding https://github.com/stuart-lab/signac/actions/runs/6070764287
I've just pushed a fix to the |
Btw, I was just having a look at the signac vignette that seems to be producing an error, and I think it's happening bc it can't find the right file path: Line 59 in 2ad6c3c
I think
Though this doesn't necessarily guarantee that the vignettes will be run in the necessary order such that the object is created before it's referenced. I suppose another option would be to add the data as a built-in dataset to Signac, or store it in the "inst/extdata" subfolder (assuming the file is small enough). |
@timoast any thoughts on this? |
Hi there!
Thanks so much for making
signac
, it's been a huge help in our lab's sc epigenomic work!I wanted to offer using
rworkflows
for your CI workflow. It's a centrally maintained GItHub Action for R package development that can:Each step is optional and easily configurable with flags:
https://github.com/bschilder/signac/blob/31a3a344300d7de6d2214e697fd05c796c0764f1/.github/workflows/rworkflows.yml#L42
Let me know if you have any questions or feature requests!
All the best, and thanks again,
Brian