[Feature] Improve breakpoint performance #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `matchMedia` function in Safari is quite slow. If we try to access the breakpoint inside an `requestAnimationFrame` loop, it gets slow.
Export Size@studiometa/js-toolkit
Unchanged@studiometa/js-toolkit
|
titouanmathis
force-pushed
the
feature/performance
branch
from
ba4cfc3 to
fa4719d
Compare
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## develop #589 +/- ##
========================================
Coverage 99.01% 99.02%
========================================
Files 122 122
Lines 4183 4186 +3
Branches 1139 1140 +1
========================================
+ Hits 4142 4145 +3
Misses 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
No issue.
β Type of change
π Description
The
matchMediafunction is really slow in Safari, adding a cache will improve performance when accessing any of the breakpoint props from the resize service.See https://jsbench.me/kpm6eyv92r/1 in different browsers.
π Checklist