Modularize CSS #364
Open
Modularize CSS #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyjensen
force-pushed
the
feature/modularize-css
branch
2 times, most recently
from
4b65d56 to
b2adc54
Compare
Laravel Mix provides a clean API for defining Webpack build steps, such as compiling SCSS files. Other developer-oriented themes (e.g., Sage by Roots) also use Laravel Mix for their build process.
timothyjensen
force-pushed
the
feature/modularize-css
branch
from
c93b860 to
03b9d5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a good deal of interest regarding moving Genesis Sample from CSS to SASS/SCSS. The discussion taking place in #315 identifies the benefit of splitting up the style sheet for performance reasons, but an even greater benefit is that SCSS files make it easier to write clean, maintainable CSS.
In #315 @nickcernis identifies some key questions about implementing a modular CSS version of Genesis Sample, and there is some valuable feedback to his questions posted in the comments.
As Nick stated, once we have some feedback on his points the next steps would include
In this PR I have made an attempt at adding the required build steps. I chose to go with Laravel Mix because it is a fairly popular choice, including the Sage theme, and the level of abstraction it affords should make it easier to maintain the build process.
I should mention that the changes proposed here offer merely a starting point. There is a lot of improvement to be made with regard to cleaning up the SCSS partials.