Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to get started from se2 landing page #179

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

LauraLangdon
Copy link
Contributor

Currently the link to "Get Started" on the SE2 landing page gives "Page Not Found" if you arrive at the SE2 landing page from the docs homepage, but not if you arrive at it from the sidebar link, because coming from the docs homepage the link is https://docs.suborbital.dev/get-started but coming from the sidebar the link is https://docs.suborbital.dev/se2/get-started.

The tidy fix would change <Link to={useBaseUrl('se2')}> in Header.jsx, but for the moment we'll just do this.

@LauraLangdon LauraLangdon added the documentation Anything related to documentation (e.g. doc bugs or similar), *not* documenting new features label Oct 4, 2022
@LauraLangdon LauraLangdon requested a review from a team October 4, 2022 16:35
@LauraLangdon LauraLangdon self-assigned this Oct 4, 2022
@vercel
Copy link

vercel bot commented Oct 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 4:35PM (UTC)

@LauraLangdon LauraLangdon mentioned this pull request Oct 4, 2022
15 tasks
@LauraLangdon LauraLangdon marked this pull request as draft October 4, 2022 18:33
@LauraLangdon LauraLangdon removed the request for review from a team October 4, 2022 18:33
@LauraLangdon
Copy link
Contributor Author

I've filed an issue to fix the A11yWatch issues: #180

I'll fix the one that's failing so we can merge this and link to the docs on the new site, but won't make fixing all them a prerequisite to merging this one.

@LauraLangdon
Copy link
Contributor Author

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139

Looks like a Rust problem?

Cheers!

@j-mendez
Copy link
Contributor

j-mendez commented Oct 4, 2022

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139

Looks like a Rust problem?

Cheers!

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139

Looks like a Rust problem?

Cheers!

Hi @LauraLangdon I can get to this issue later today. Indeed a Rust problem, thank you!

@j-mendez
Copy link
Contributor

j-mendez commented Oct 4, 2022

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139
Looks like a Rust problem?
Cheers!

Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139
Looks like a Rust problem?
Cheers!

Hi @LauraLangdon I can get to this issue later today. Indeed a Rust problem, thank you!

@LauraLangdon you may be able to re-run the action and not get the error. Looking at the action time it ran - 5 hours ago there was a small bug pushed that has been fixed.

@LauraLangdon
Copy link
Contributor Author

Looks like the error persists, @j-mendez. #180

Thanks so much for your help!

@j-mendez
Copy link
Contributor

j-mendez commented Oct 4, 2022

Looks like the error persists, @j-mendez. #180

Thanks so much for your help!

You are welcome, it looks like the docker image for the fix was not tagged so the version needs a hard update on the GH action to update this time.

      - uses: A11yWatch/[email protected]
        with:
          WEBSITE_URL: https://docs.suborbital.dev
          FAIL_ERRORS_COUNT: 3
          UPGRADE: true
          # 3 is the number of warnings we get from Docusaurus-level code we can't fix, so this will
          # be the error floor for now
          TOKEN: ${{ secrets.GITHUB_TOKEN }}

After the upgrade reverting the flag to improve the speed of the CLI or keep it can be done.

@github-actions
Copy link

7 total issues, 1 error, and 6 warnings found for docs.suborbital.dev

Details

ERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail
<span class="DocSearch-Button-Placeholder">Search</span>

This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610.



WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48
<div class="home__flagship__item"><a href="/sat" class="link"><im...</div>

If this element contains a navigation section, it is recommended that it be marked up as a list.



WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48
<div class="home__flagship__item"><a href="/atmo" class="link"><i...</div>

If this element contains a navigation section, it is recommended that it be marked up as a list.



WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48
<div class="navbar__items navbar__items--right"><a href="https://suborbital.dev...</div>

If this element contains a navigation section, it is recommended that it be marked up as a list.



WARNING WCAG2AA.Principle1.Guideline1_4.1_4_10.C32,C31,C33,C38,SCR34,G206
<a href="#" class="skipToContent_fXgn">Skip to main content</a>

This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion.



WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour
<span id="docusaurus-base-url-issue-banner-suggestion-container" style="font-weight: bold; color: green;">/</span>

Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour.



WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour
<span style="font-weight: bold; color: red;">/</span>

Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour.



📝 docs | :octocat: repo | 🙋🏽‍♀️ issues | 🏪 marketplace | A11yWatch

@LauraLangdon LauraLangdon requested a review from a team October 12, 2022 01:31
@LauraLangdon LauraLangdon marked this pull request as ready for review October 12, 2022 01:31
@MacklinEngineering MacklinEngineering self-requested a review October 12, 2022 01:34
Copy link

@MacklinEngineering MacklinEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work driving this to completion!

@LauraLangdon LauraLangdon merged commit 5c0dd3e into main Oct 12, 2022
@LauraLangdon LauraLangdon deleted the laura/fix-homepage-link-to-se2 branch November 25, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to documentation (e.g. doc bugs or similar), *not* documenting new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants