-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix link to get started from se2 landing page #179
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I've filed an issue to fix the A11yWatch issues: #180 I'll fix the one that's failing so we can merge this and link to the docs on the new site, but won't make fixing all them a prerequisite to merging this one. |
Hi @j-mendez! We're getting a failure on our test runs, and wondering if you might have any insight into it on your end. Here's the failure: https://github.com/suborbital/docs/actions/runs/3183863502/jobs/5191587868#step:3:139 Looks like a Rust problem? Cheers! |
Hi @LauraLangdon I can get to this issue later today. Indeed a Rust problem, thank you! |
@LauraLangdon you may be able to re-run the action and not get the error. Looking at the action time it ran - 5 hours ago there was a small bug pushed that has been fixed. |
You are welcome, it looks like the docker image for the fix was not tagged so the version needs a hard update on the GH action to update this time.
After the upgrade reverting the flag to improve the speed of the CLI or keep it can be done. |
7 total issues, 1 error, and 6 warnings found for docs.suborbital.devDetailsERROR WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail <span class="DocSearch-Button-Placeholder">Search</span> This element has insufficient contrast at this conformance level. Expected a contrast ratio of at least 4.5:1, but text in this element has a contrast ratio of 2.27:1. Recommendation: change text colour to #000610. WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 <div class="home__flagship__item"><a href="/sat" class="link"><im...</div> If this element contains a navigation section, it is recommended that it be marked up as a list. WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 <div class="home__flagship__item"><a href="/atmo" class="link"><i...</div> If this element contains a navigation section, it is recommended that it be marked up as a list. WARNING WCAG2AA.Principle1.Guideline1_3.1_3_1.H48 <div class="navbar__items navbar__items--right"><a href="https://suborbital.dev...</div>
If this element contains a navigation section, it is recommended that it be marked up as a list. WARNING WCAG2AA.Principle1.Guideline1_4.1_4_10.C32,C31,C33,C38,SCR34,G206 <a href="#" class="skipToContent_fXgn">Skip to main content</a> This element has "position: fixed". This may require scrolling in two dimensions, which is considered a failure of this Success Criterion. WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour <span id="docusaurus-base-url-issue-banner-suggestion-container" style="font-weight: bold; color: green;">/</span> Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. WARNING WCAG2AA.Principle1.Guideline1_4.1_4_3_F24.F24.FGColour <span style="font-weight: bold; color: red;">/</span> Check that this element has an inherited background colour or image to complement the corresponding inline foreground colour. 📝 docs | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work driving this to completion!
Currently the link to "Get Started" on the SE2 landing page gives "Page Not Found" if you arrive at the SE2 landing page from the docs homepage, but not if you arrive at it from the sidebar link, because coming from the docs homepage the link is https://docs.suborbital.dev/get-started but coming from the sidebar the link is https://docs.suborbital.dev/se2/get-started.
The tidy fix would change
<Link to={useBaseUrl('se2')}>
in Header.jsx, but for the moment we'll just do this.