fix: Aggressively GC wasm instances (#428)

suborbital · May 3, 2023 · 49c96d2 · 49c96d2
1 parent 0e40fe5
commit 49c96d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/e2core/command/mod_start.go b/e2core/command/mod_start.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"os"
 	"os/signal"
+	"runtime/debug"
 	"syscall"
 	"time"
 
@@ -76,6 +77,10 @@ func ModStart() *cobra.Command {
 
 			serverErrors := make(chan error, 1)
 
+			// Wasmtime mmaps huge chunks of memory per module instantiation, so we instruct the GC to aggressively
+			// reclaim memory to prevent OOMs
+			debug.SetGCPercent(15)
+
 			go func() {
 				l.Info().Msg("starting server")
 				err := satInstance.Start()

diff --git a/sat/engine2/runtime/instance/instance.go b/sat/engine2/runtime/instance/instance.go
@@ -135,6 +135,7 @@ func (w *Instance) UseCtx(ctx *scheduler.Ctx) {
 func (w *Instance) Close() {
 	w.inst = nil
 	w.ctx = nil
+	w.store = nil
 	w.resultChan = nil
 	w.errChan = nil
 }