-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for simple extensions dependencies #265
feat: support for simple extensions dependencies #265
Conversation
This one has been on my mental TODO list for a while now: it's currently impossible for an extension to define functions that make use of types from another extension. Some problems with that:
AFAICT, the only missing link for supporting this as far as the specification is concerned is the lack of a way to define and refer to extension URI dependencies in YAML, so that's what this PR adds. |
c36da3a
to
c332f15
Compare
Seems reasonable. Do you want to also write up some markdown for this? |
c332f15
to
d963a92
Compare
Yep, good point. |
d963a92
to
e215618
Compare
|
site/docs/extensions/index.md
Outdated
|
||
```yaml | ||
dependencies: | ||
ext: /extension_types.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a valid URI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a valid URI reference which we tend to accept in implementations. To make this a better example we could just prepend file:
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made that change.
No description provided.