Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add simple linking to the examples #702

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

mbwhite
Copy link
Contributor

@mbwhite mbwhite commented Sep 9, 2024

Simple description of the examples and a link to the new one added in the substrait-java repo; this will need to wait until after that is merged to ensure no broken links.,

@mbwhite mbwhite marked this pull request as ready for review October 7, 2024 08:53
bvolpato
bvolpato previously approved these changes Dec 3, 2024
Copy link
Member

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nit suggestions / ideas to make it clearer

site/docs/tutorial/examples.md Outdated Show resolved Hide resolved
site/docs/tutorial/examples.md Outdated Show resolved Hide resolved
@mbwhite
Copy link
Contributor Author

mbwhite commented Dec 4, 2024

thanks @bvolpato I've accepted those changes

@EpsilonPrime EpsilonPrime merged commit 4c00b1c into substrait-io:main Dec 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants