Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: specify row_number start (#722) #723

Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat: specify row_number start (#722) #723

merged 1 commit into from
Oct 8, 2024

Conversation

vbarua
Copy link
Member

@vbarua vbarua commented Oct 8, 2024

row_number should start counting rows at 1

@vbarua
feat: specify row_number start
31db869 
row_number should start counting rows at 1
@vbarua
Copy link
Member Author

vbarua commented Oct 8, 2024

Looking at common engines, row_number starts at 1:

Addresses #722

EpsilonPrime
EpsilonPrime approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@EpsilonPrime EpsilonPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like DuckDB and Spark also start at 1.

@vbarua vbarua merged commit a0388ff into main Oct 8, 2024
13 checks passed
@vbarua vbarua deleted the vbarua/row_number_start branch October 8, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

@jacques-n jacques-n jacques-n approved these changes

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vbarua @EpsilonPrime @jacques-n @westonpace